diff options
| author | Thomas Huth <thuth@redhat.com> | 2022-07-04 13:18:56 +0200 |
|---|---|---|
| committer | Thomas Huth <thuth@redhat.com> | 2022-07-06 18:34:13 +0200 |
| commit | 5447de2619050a0a4dd480b97f88a9b58da360d1 (patch) | |
| tree | 7bcc682d4de8f6c46ea967e49f06424f2b4f029a /pc-bios/s390-ccw/virtio.h | |
| parent | bbf615f7b707f009ef8e757d170902ad33b90644 (diff) | |
pc-bios/s390-ccw/virtio-blkdev: Remove virtio_assume_scsi()
The virtio_assume_scsi() function is very questionable: First, it
is only called for virtio-blk, and not for virtio-scsi, so the naming
is already quite confusing. Second, it is called if we detected a
"invalid" IPL disk, trying to fix it by blindly setting a sector
size of 512. This of course won't work in most cases since disks
might have a different sector size for a reason.
Thus let's remove this strange function now. The calling code can
also be removed completely, since there is another spot in main.c
that does "IPL_assert(virtio_ipl_disk_is_valid(), ...)" to make
sure that we do not try to IPL from an invalid device.
Message-Id: <20220704111903.62400-6-thuth@redhat.com>
Reviewed-by: Eric Farman <farman@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'pc-bios/s390-ccw/virtio.h')
| -rw-r--r-- | pc-bios/s390-ccw/virtio.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/pc-bios/s390-ccw/virtio.h b/pc-bios/s390-ccw/virtio.h index 241730effe..600ba5052b 100644 --- a/pc-bios/s390-ccw/virtio.h +++ b/pc-bios/s390-ccw/virtio.h @@ -182,7 +182,6 @@ enum guessed_disk_nature_type { typedef enum guessed_disk_nature_type VirtioGDN; VirtioGDN virtio_guessed_disk_nature(void); -void virtio_assume_scsi(void); void virtio_assume_eckd(void); void virtio_assume_iso9660(void); |