aboutsummaryrefslogtreecommitdiff
path: root/pc-bios/s390-ccw/helper.h
diff options
context:
space:
mode:
authorMax Reitz <mreitz@redhat.com>2020-06-30 10:37:11 +0200
committerKevin Wolf <kwolf@redhat.com>2020-07-03 09:54:07 +0200
commit49438972b8c2e16cf1f98b1b2355926e8c633e63 (patch)
tree3b2cd201eece96bd571be08dda7bf8b55c36685c /pc-bios/s390-ccw/helper.h
parent3dfa23b9eff4315817c1acf59711b8414347de31 (diff)
iotests.py: Do not wait() before communicate()
Waiting on a process for which we have a pipe will stall if the process outputs more data than fits into the OS-provided buffer. We must use communicate() before wait(), and in fact, communicate() perfectly replaces wait() already. We have to drop the stderr=subprocess.STDOUT parameter from subprocess.Popen() in qemu_nbd_early_pipe(), because stderr is passed on to the child process, so if we do not drop this parameter, communicate() will hang (because the pipe is not closed). Signed-off-by: Max Reitz <mreitz@redhat.com> Message-Id: <20200630083711.40567-1-mreitz@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'pc-bios/s390-ccw/helper.h')
0 files changed, 0 insertions, 0 deletions