aboutsummaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé <f4bug@amsat.org>2020-08-22 20:09:49 +0200
committerLaurent Vivier <laurent@vivier.eu>2020-09-11 21:25:59 +0200
commit67263b33af9506d78558b1edfa5a9bf976dc7b3d (patch)
treead3ac55019240c2efb2cb67bcd24cbe0bf76bdbb /net
parent5ace4cc0e8d818d578b3777a23d477a5e42070eb (diff)
util/hexdump: Convert to take a void pointer argument
Most uses of qemu_hexdump() do not take an array of char as input, forcing use of cast. Since we can use this helper to dump any kind of buffer, use a pointer to void argument instead. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> Reviewed-by: Li Qiang <liq3ea@gmail.com> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> Message-Id: <20200822180950.1343963-2-f4bug@amsat.org> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Diffstat (limited to 'net')
-rw-r--r--net/colo-compare.c12
-rw-r--r--net/net.c2
2 files changed, 7 insertions, 7 deletions
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 2c20de1537..550272b3ba 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -494,9 +494,9 @@ sec:
g_queue_push_head(&conn->secondary_list, spkt);
if (trace_event_get_state_backends(TRACE_COLO_COMPARE_MISCOMPARE)) {
- qemu_hexdump((char *)ppkt->data, stderr,
+ qemu_hexdump(ppkt->data, stderr,
"colo-compare ppkt", ppkt->size);
- qemu_hexdump((char *)spkt->data, stderr,
+ qemu_hexdump(spkt->data, stderr,
"colo-compare spkt", spkt->size);
}
@@ -535,9 +535,9 @@ static int colo_packet_compare_udp(Packet *spkt, Packet *ppkt)
trace_colo_compare_udp_miscompare("primary pkt size", ppkt->size);
trace_colo_compare_udp_miscompare("Secondary pkt size", spkt->size);
if (trace_event_get_state_backends(TRACE_COLO_COMPARE_MISCOMPARE)) {
- qemu_hexdump((char *)ppkt->data, stderr, "colo-compare pri pkt",
+ qemu_hexdump(ppkt->data, stderr, "colo-compare pri pkt",
ppkt->size);
- qemu_hexdump((char *)spkt->data, stderr, "colo-compare sec pkt",
+ qemu_hexdump(spkt->data, stderr, "colo-compare sec pkt",
spkt->size);
}
return -1;
@@ -578,9 +578,9 @@ static int colo_packet_compare_icmp(Packet *spkt, Packet *ppkt)
trace_colo_compare_icmp_miscompare("Secondary pkt size",
spkt->size);
if (trace_event_get_state_backends(TRACE_COLO_COMPARE_MISCOMPARE)) {
- qemu_hexdump((char *)ppkt->data, stderr, "colo-compare pri pkt",
+ qemu_hexdump(ppkt->data, stderr, "colo-compare pri pkt",
ppkt->size);
- qemu_hexdump((char *)spkt->data, stderr, "colo-compare sec pkt",
+ qemu_hexdump(spkt->data, stderr, "colo-compare sec pkt",
spkt->size);
}
return -1;
diff --git a/net/net.c b/net/net.c
index bbaedb3c7a..f3e5d533fd 100644
--- a/net/net.c
+++ b/net/net.c
@@ -636,7 +636,7 @@ static ssize_t qemu_send_packet_async_with_flags(NetClientState *sender,
#ifdef DEBUG_NET
printf("qemu_send_packet_async:\n");
- qemu_hexdump((const char *)buf, stdout, "net", size);
+ qemu_hexdump(buf, stdout, "net", size);
#endif
if (sender->link_down || !sender->peer) {