aboutsummaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorJason Wang <jasowang@redhat.com>2021-04-02 11:03:20 +0800
committerJason Wang <jasowang@redhat.com>2021-04-08 17:33:59 +0800
commit603f2f7c6c8c747d0189936a74fb33e610ce7858 (patch)
treee940c7db13a812592ae647a494a1a5b205186f51 /net
parentd89b4f839f0770a3adbedd5a727482f0aa2478a6 (diff)
Revert "hmp: Use QAPI NetdevInfo in hmp_info_network"
Several issues has been reported for query-netdev info series. Consider it's late in the rc, this reverts commit a0724776c5a98a08fc946bb5a4ad16410ca64c0e. Signed-off-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'net')
-rw-r--r--net/net.c31
1 files changed, 1 insertions, 30 deletions
diff --git a/net/net.c b/net/net.c
index 725a4e1450..277da712eb 100644
--- a/net/net.c
+++ b/net/net.c
@@ -55,7 +55,6 @@
#include "sysemu/sysemu.h"
#include "net/filter.h"
#include "qapi/string-output-visitor.h"
-#include "qapi/hmp-output-visitor.h"
/* Net bridge is currently not supported for W32. */
#if !defined(_WIN32)
@@ -1222,42 +1221,14 @@ static void netfilter_print_info(Monitor *mon, NetFilterState *nf)
monitor_printf(mon, "\n");
}
-static char *generate_info_str(NetClientState *nc)
-{
- NetdevInfo *ni = nc->stored_config;
- char *ret_out = NULL;
- Visitor *v;
-
- /* Use legacy field info_str for NIC and hubports */
- if ((nc->info->type == NET_CLIENT_DRIVER_NIC) ||
- (nc->info->type == NET_CLIENT_DRIVER_HUBPORT)) {
- return g_strdup(nc->info_str ? nc->info_str : "");
- }
-
- if (!ni) {
- return g_malloc0(1);
- }
-
- v = hmp_output_visitor_new(&ret_out);
- if (visit_type_NetdevInfo(v, "", &ni, NULL)) {
- visit_complete(v, &ret_out);
- }
- visit_free(v);
-
- return ret_out;
-}
-
void print_net_client(Monitor *mon, NetClientState *nc)
{
NetFilterState *nf;
- char *info_str = generate_info_str(nc);
monitor_printf(mon, "%s: index=%d,type=%s,%s\n", nc->name,
nc->queue_index,
NetClientDriver_str(nc->info->type),
- info_str);
- g_free(info_str);
-
+ nc->info_str ? nc->info_str : "");
if (!QTAILQ_EMPTY(&nc->filters)) {
monitor_printf(mon, "filters:\n");
}