diff options
author | Eric Blake <eblake@redhat.com> | 2023-09-25 14:22:38 -0500 |
---|---|---|
committer | Eric Blake <eblake@redhat.com> | 2023-10-05 11:02:08 -0500 |
commit | a7c18670b429cc5e9c5e6a25cc401dc93086f1a7 (patch) | |
tree | c44a0a09b13ce3d1cfd640481202fdf473ed4cf9 /nbd | |
parent | 4fc55bf3b0608f15ce64d7b8cdaa95ac29e62d6c (diff) |
nbd/client: Accept 64-bit block status chunks
Once extended mode is enabled, we need to accept 64-bit status replies
(even for replies that don't exceed a 32-bit length). It is easier to
normalize narrow replies into wide format so that the rest of our code
only has to handle one width. Although a server is non-compliant if
it sends a 64-bit reply in compact mode, or a 32-bit reply in extended
mode, it is still easy enough to tolerate these mismatches.
In normal execution, we are only requesting "base:allocation" which
never exceeds 32 bits for flag values. But during testing with
x-dirty-bitmap, we can force qemu to connect to some other context
that might have 64-bit status bit; however, we ignore those upper bits
(other than mapping qemu:allocation-depth into something that
'qemu-img map --output=json' can expose), and since that only affects
testing, we really don't bother with checking whether more than the
two least-significant bits are set.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-ID: <20230925192229.3186470-22-eblake@redhat.com>
Diffstat (limited to 'nbd')
0 files changed, 0 insertions, 0 deletions