aboutsummaryrefslogtreecommitdiff
path: root/monitor.c
diff options
context:
space:
mode:
authorMarc-André Lureau <marcandre.lureau@redhat.com>2017-01-05 14:59:57 +0100
committerMarkus Armbruster <armbru@redhat.com>2017-01-19 15:42:36 +0100
commit0d6b50d474090b9085c595e2475c40cfdc092411 (patch)
tree20a2aa9aa4a896992a7de6efedc1770c565b2bed /monitor.c
parent98cb89af4df7e1776ce418ed6167b6e214a64435 (diff)
error: Report certain hints on stderr when no monitor
Hints printed with error_printf_unless_qmp() are suppressed outside monitor context. Reproducer: $ qemu-system-x86_64 -m 1Z qemu-system-x86_64: -m 1Z: Parameter 'size' expects a size Print to stderr instead. The reproducer now additionally prints: You may use k, M, G or T suffixes for kilobytes, megabytes, gigabytes and terabytes. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> Message-Id: <20170105135957.12003-1-marcandre.lureau@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> [Commit message tweaked] Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'monitor.c')
-rw-r--r--monitor.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/monitor.c b/monitor.c
index 0841d436b0..90c5bafcc3 100644
--- a/monitor.c
+++ b/monitor.c
@@ -3973,6 +3973,8 @@ void error_vprintf_unless_qmp(const char *fmt, va_list ap)
{
if (cur_mon && !monitor_cur_is_qmp()) {
monitor_vprintf(cur_mon, fmt, ap);
+ } else if (!cur_mon) {
+ vfprintf(stderr, fmt, ap);
}
}