diff options
| author | Markus Armbruster <armbru@redhat.com> | 2017-07-18 12:57:38 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2017-07-24 13:35:11 +0200 |
| commit | e87fae4c488ff8a10b921311a63f16b94031c611 (patch) | |
| tree | e292b6f138bf2f83423fe5e9a6992925cc1dfb63 /migration | |
| parent | 8cc99dcdc264bc896926e43e7576c7b7ab633d70 (diff) | |
migration: Add TODO comments on duplication of QAPI_CLONE()
qmp_query_migrate_parameters() and qmp_migrate_set_parameters()
effectively duplicate QAPI_CLONE() inline. Add suitable TODO
comments.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'migration')
| -rw-r--r-- | migration/migration.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/migration/migration.c b/migration/migration.c index 88b9277e68..6b4d17fbb5 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -433,6 +433,7 @@ MigrationParameters *qmp_query_migrate_parameters(Error **errp) MigrationParameters *params; MigrationState *s = migrate_get_current(); + /* TODO use QAPI_CLONE() instead of duplicating it inline */ params = g_malloc0(sizeof(*params)); params->has_compress_level = true; params->compress_level = s->parameters.compress_level; @@ -745,6 +746,8 @@ static void migrate_params_apply(MigrationParameters *params) { MigrationState *s = migrate_get_current(); + /* TODO use QAPI_CLONE() instead of duplicating it inline */ + if (params->has_compress_level) { s->parameters.compress_level = params->compress_level; } |