aboutsummaryrefslogtreecommitdiff
path: root/migration/ram-compress.c
diff options
context:
space:
mode:
authorJuan Quintela <quintela@redhat.com>2023-10-19 13:07:17 +0200
committerJuan Quintela <quintela@redhat.com>2023-10-30 17:41:55 +0100
commit83df387df7fbd4fb76f3beae56f925dead5bba5a (patch)
tree1fcb8e6f6c8b75270a2d5326aa8d82ebde9ef9bc /migration/ram-compress.c
parent4e400f9091d496c513fcd513753a2d681be57a3b (diff)
migration: Make compress_data_with_multithreads return bool
Reviewed-by: Lukas Straub <lukasstraub2@web.de> Reviewed-by: Fabiano Rosas <farosas@suse.de> Signed-off-by: Juan Quintela <quintela@redhat.com> Message-ID: <20231019110724.15324-5-quintela@redhat.com>
Diffstat (limited to 'migration/ram-compress.c')
-rw-r--r--migration/ram-compress.c17
1 files changed, 10 insertions, 7 deletions
diff --git a/migration/ram-compress.c b/migration/ram-compress.c
index d037dfe6cf..ef03d60a6d 100644
--- a/migration/ram-compress.c
+++ b/migration/ram-compress.c
@@ -260,10 +260,13 @@ static inline void set_compress_params(CompressParam *param, RAMBlock *block,
param->trigger = true;
}
-int compress_page_with_multi_thread(RAMBlock *block, ram_addr_t offset,
- int (send_queued_data(CompressParam *)))
+/*
+ * Return true when it compress a page
+ */
+bool compress_page_with_multi_thread(RAMBlock *block, ram_addr_t offset,
+ int (send_queued_data(CompressParam *)))
{
- int thread_count, pages = -1;
+ int thread_count;
bool wait = migrate_compress_wait_thread();
thread_count = migrate_compress_threads();
@@ -281,8 +284,8 @@ retry:
qemu_cond_signal(&param->cond);
qemu_mutex_unlock(&param->mutex);
- pages = 1;
- break;
+ qemu_mutex_unlock(&comp_done_lock);
+ return true;
}
}
@@ -290,13 +293,13 @@ retry:
* wait for the free thread if the user specifies 'compress-wait-thread',
* otherwise we will post the page out in the main thread as normal page.
*/
- if (pages < 0 && wait) {
+ if (wait) {
qemu_cond_wait(&comp_done_cond, &comp_done_lock);
goto retry;
}
qemu_mutex_unlock(&comp_done_lock);
- return pages;
+ return false;
}
/* return the size after decompression, or negative value on error */