diff options
author | Christian Borntraeger <borntraeger@de.ibm.com> | 2012-08-10 15:11:45 +0200 |
---|---|---|
committer | Avi Kivity <avi@redhat.com> | 2012-09-09 16:48:34 +0300 |
commit | 62fe83318d2fc5b31f473d66326910d94c1c4907 (patch) | |
tree | 89d23660c8b2cefc9b309a0de03dee5c7ac3ec04 /memory.c | |
parent | 0c267217ca9985e6d118ec8368bebd382db7a099 (diff) |
qemu: Use valgrind annotations to mark kvm guest memory as defined
valgrind with kvm produces a big amount of false positives regarding
"Conditional jump or move depends on uninitialised value(s)". This
happens because the guest memory is allocated with qemu_vmalloc which
boils down posix_memalign etc. This function is (correctly) considered
by valgrind as returning undefined memory.
Since valgrind is based on jitting code, it will not be able to see
changes made by the guest to guest memory if this is done by KVM_RUN,
thus keeping most of the guest memory undefined.
Now lots of places in qemu will then use guest memory to change behaviour.
To avoid the flood of these messages, lets declare the whole guest
memory as defined. This will reduce the noise and allows us to see real
problems.
In the future we might want to make this conditional, since there
is actually something that we can use those false positives for:
These messages will point to code that depends on guest memory, so
we can use these backtraces to actually make an audit that is focussed
only at those code places. For normal development we dont want to
see those messages, though.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
Diffstat (limited to 'memory.c')
0 files changed, 0 insertions, 0 deletions