aboutsummaryrefslogtreecommitdiff
path: root/io/task.c
diff options
context:
space:
mode:
authorAlberto Garcia <berto@igalia.com>2019-08-12 18:58:28 +0300
committerPaolo Bonzini <pbonzini@redhat.com>2019-08-21 16:31:58 +0200
commitb65cb867cc13b581baeea7648a9f45899cb7a714 (patch)
tree33ae175238c5ffdb6236974079848867e8f5c67e /io/task.c
parentb960fc1796fb078c21121abf01499603b66b3f57 (diff)
main-loop: Fix GSource leak in qio_task_thread_worker()
After g_source_attach() the GMainContext holds a reference to the GSource, so the caller does not need to keep it. qio_task_thread_worker() is not releasing its reference so the GSource is being leaked since a17536c594bfed94d05667b419f747b692f5fc7f. Signed-off-by: Alberto Garcia <berto@igalia.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Message-Id: <1565625509-404969-2-git-send-email-andrey.shinkevich@virtuozzo.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'io/task.c')
-rw-r--r--io/task.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/io/task.c b/io/task.c
index 64c4c7126a..1ae7b86488 100644
--- a/io/task.c
+++ b/io/task.c
@@ -136,6 +136,7 @@ static gpointer qio_task_thread_worker(gpointer opaque)
qio_task_thread_result, task, NULL);
g_source_attach(task->thread->completion,
task->thread->context);
+ g_source_unref(task->thread->completion);
trace_qio_task_thread_source_attach(task, task->thread->completion);
qemu_cond_signal(&task->thread_cond);