diff options
| author | Cédric Le Goater <clg@redhat.com> | 2023-12-21 16:58:41 +0100 |
|---|---|---|
| committer | Cédric Le Goater <clg@redhat.com> | 2024-01-05 21:25:20 +0100 |
| commit | 19368b1905b4b917e915526fcbd5bfa3f7439451 (patch) | |
| tree | 68c1386eca69463621a74ecde5d6e4f4abb9a859 /include | |
| parent | c2ab3a6f7411c895e538e8350fee8948ac07c1a0 (diff) | |
backends/iommufd: Remove mutex
Coverity reports a concurrent data access violation because be->users
is being accessed in iommufd_backend_can_be_deleted() without holding
the mutex.
However, these routines are called from the QEMU main thread when a
device is created. In this case, the code paths should be protected by
the BQL lock and it should be safe to drop the IOMMUFD backend mutex.
Simply remove it.
Fixes: CID 1531550
Fixes: CID 1531549
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/sysemu/iommufd.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/include/sysemu/iommufd.h b/include/sysemu/iommufd.h index 9c5524b0ed..9af27ebd6c 100644 --- a/include/sysemu/iommufd.h +++ b/include/sysemu/iommufd.h @@ -2,7 +2,6 @@ #define SYSEMU_IOMMUFD_H #include "qom/object.h" -#include "qemu/thread.h" #include "exec/hwaddr.h" #include "exec/cpu-common.h" @@ -19,7 +18,6 @@ struct IOMMUFDBackend { /*< protected >*/ int fd; /* /dev/iommu file descriptor */ bool owned; /* is the /dev/iommu opened internally */ - QemuMutex lock; uint32_t users; /*< public >*/ |