diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2018-04-19 13:04:01 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2018-05-23 14:30:50 +0200 |
| commit | dbe5e6c1f73b41282624b78a2375a5c3ee59e905 (patch) | |
| tree | ec2cad34f5b7d8a067166b251ab7743c86a595a1 /include | |
| parent | b15de82867975e0b4acf644b5ee36d84904b6612 (diff) | |
job: Replace BlockJob.completed with job_is_completed()
Since we introduced an explicit status to block job, BlockJob.completed
is redundant because it can be derived from the status. Remove the field
from BlockJob and add a function to derive it from the status at the Job
level.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/block/blockjob.h | 3 | ||||
| -rw-r--r-- | include/qemu/job.h | 3 |
2 files changed, 3 insertions, 3 deletions
diff --git a/include/block/blockjob.h b/include/block/blockjob.h index 556a8f6375..3e94e18850 100644 --- a/include/block/blockjob.h +++ b/include/block/blockjob.h @@ -88,9 +88,6 @@ typedef struct BlockJob { /** The opaque value that is passed to the completion function. */ void *opaque; - /** True when job has reported completion by calling block_job_completed. */ - bool completed; - /** ret code passed to block_job_completed. */ int ret; diff --git a/include/qemu/job.h b/include/qemu/job.h index bc6398568f..858f3beea4 100644 --- a/include/qemu/job.h +++ b/include/qemu/job.h @@ -214,6 +214,9 @@ const char *job_type_str(const Job *job); /** Returns whether the job is scheduled for cancellation. */ bool job_is_cancelled(Job *job); +/** Returns whether the job is in a completed state. */ +bool job_is_completed(Job *job); + /** * Request @job to pause at the next pause point. Must be paired with * job_resume(). If the job is supposed to be resumed by user action, call |