diff options
author | Peter Maydell <peter.maydell@linaro.org> | 2014-03-28 15:29:46 +0000 |
---|---|---|
committer | Richard Henderson <rth@twiddle.net> | 2014-05-12 10:03:04 -0700 |
commit | 86360ad71df0070283469b8ae59f33cdd013501d (patch) | |
tree | 45f6fb13e9e2887e45ca70259a2cdc95ad8a0ea0 /include/sysemu | |
parent | 06b4f00d53637f2c16a62c2cbaa30bffb045cf88 (diff) |
exec-all.h: Use stl_p to avoid undefined behaviour patching x86 jumps
The code which patches x86 jump instructions assumes it can do an
unaligned write of a uint32_t. This is actually safe on x86, but it's
still undefined behaviour. We have infrastructure for doing efficient
unaligned accesses which doesn't engage in undefined behaviour, so
use it.
This is technically fractionally less efficient, at least with gcc 4.6;
instead of one instruction:
7b2: 89 3e mov %edi,(%rsi)
we get an extra spurious store to the stack slot:
7b2: 89 7c 24 64 mov %edi,0x64(%rsp)
7b6: 89 3e mov %edi,(%rsi)
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Diffstat (limited to 'include/sysemu')
0 files changed, 0 insertions, 0 deletions