diff options
| author | Stefan Hajnoczi <stefanha@redhat.com> | 2014-02-20 12:14:07 +0100 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@redhat.com> | 2014-02-25 14:31:05 +0100 |
| commit | d6085e3ace20bc9b0fa625d8d79b22668710e217 (patch) | |
| tree | 96a930a0ad6f56f61725189fdfe9a3c6f4a901e9 /include/net | |
| parent | 0a985b37272b563b1f8414431c6064eb1aa0c97b (diff) | |
net: remove implicit peer from offload API
The virtio_net offload APIs are used on the NIC's peer (i.e. the tap
device). The API was defined to implicitly use nc->peer, saving the
caller the trouble.
This wasn't ideal because:
1. There are callers who have the peer but not the NIC. Currently they
are forced to bypass the API and access peer->info->... directly.
2. The rest of the net.h API uses nc, not nc->peer, so it is
inconsistent.
This patch pushes nc->peer back up to callers.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'include/net')
| -rw-r--r-- | include/net/net.h | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/include/net/net.h b/include/net/net.h index 7b2539433b..8166345a13 100644 --- a/include/net/net.h +++ b/include/net/net.h @@ -132,13 +132,13 @@ ssize_t qemu_send_packet_async(NetClientState *nc, const uint8_t *buf, void qemu_purge_queued_packets(NetClientState *nc); void qemu_flush_queued_packets(NetClientState *nc); void qemu_format_nic_info_str(NetClientState *nc, uint8_t macaddr[6]); -bool qemu_peer_has_ufo(NetClientState *nc); -bool qemu_peer_has_vnet_hdr(NetClientState *nc); -bool qemu_peer_has_vnet_hdr_len(NetClientState *nc, int len); -void qemu_peer_using_vnet_hdr(NetClientState *nc, bool enable); -void qemu_peer_set_offload(NetClientState *nc, int csum, int tso4, int tso6, - int ecn, int ufo); -void qemu_peer_set_vnet_hdr_len(NetClientState *nc, int len); +bool qemu_has_ufo(NetClientState *nc); +bool qemu_has_vnet_hdr(NetClientState *nc); +bool qemu_has_vnet_hdr_len(NetClientState *nc, int len); +void qemu_using_vnet_hdr(NetClientState *nc, bool enable); +void qemu_set_offload(NetClientState *nc, int csum, int tso4, int tso6, + int ecn, int ufo); +void qemu_set_vnet_hdr_len(NetClientState *nc, int len); void qemu_macaddr_default_if_unset(MACAddr *macaddr); int qemu_show_nic_models(const char *arg, const char *const *models); void qemu_check_nic_model(NICInfo *nd, const char *model); |