diff options
author | Anthony Liguori <aliguori@us.ibm.com> | 2012-01-23 07:30:43 -0600 |
---|---|---|
committer | Anthony Liguori <aliguori@us.ibm.com> | 2012-01-23 07:30:43 -0600 |
commit | 65f82df0d7a71ce1b10cd4c5ab08888d176ac840 (patch) | |
tree | 6ba62af47e5265cff76471451a5e8fc32d143334 /hw | |
parent | 520c0d8d2772ccc9f9275bd934e13ec9b15774e4 (diff) |
e1000: bounds packet size against buffer size
Otherwise we can write beyond the buffer and corrupt memory. This is tracked
as CVE-2012-0029.
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'hw')
-rw-r--r-- | hw/e1000.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/hw/e1000.c b/hw/e1000.c index a29c944df4..86c5416bd1 100644 --- a/hw/e1000.c +++ b/hw/e1000.c @@ -466,6 +466,8 @@ process_tx_desc(E1000State *s, struct e1000_tx_desc *dp) bytes = split_size; if (tp->size + bytes > msh) bytes = msh - tp->size; + + bytes = MIN(sizeof(tp->data) - tp->size, bytes); pci_dma_read(&s->dev, addr, tp->data + tp->size, bytes); if ((sz = tp->size + bytes) >= hdr && tp->size < hdr) memmove(tp->header, tp->data, hdr); @@ -481,6 +483,7 @@ process_tx_desc(E1000State *s, struct e1000_tx_desc *dp) // context descriptor TSE is not set, while data descriptor TSE is set DBGOUT(TXERR, "TCP segmentaion Error\n"); } else { + split_size = MIN(sizeof(tp->data) - tp->size, split_size); pci_dma_read(&s->dev, addr, tp->data + tp->size, split_size); tp->size += split_size; } |