diff options
| author | Jan Beulich <jbeulich@suse.com> | 2015-06-02 15:07:00 +0000 |
|---|---|---|
| committer | Stefano Stabellini <stefano.stabellini@eu.citrix.com> | 2015-06-02 15:07:00 +0000 |
| commit | 5c83b2f5b4b956e91dd6e5711f14df7ab800aefb (patch) | |
| tree | 2ecb2b7bb863087b3288056ea312761dbc68a9c0 /hw/xen/xen_pt.h | |
| parent | 3fc827d591679f3e262b9d1f8b34528eabfca8c0 (diff) | |
xen: properly gate host writes of modified PCI CFG contents
The old logic didn't work as intended when an access spanned multiple
fields (for example a 32-bit access to the location of the MSI Message
Data field with the high 16 bits not being covered by any known field).
Remove it and derive which fields not to write to from the accessed
fields' emulation masks: When they're all ones, there's no point in
doing any host write.
This fixes a secondary issue at once: We obviously shouldn't make any
host write attempt when already the host read failed.
This is XSA-128.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Diffstat (limited to 'hw/xen/xen_pt.h')
| -rw-r--r-- | hw/xen/xen_pt.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h index 942dc60cc7..52ceb856f9 100644 --- a/hw/xen/xen_pt.h +++ b/hw/xen/xen_pt.h @@ -105,8 +105,6 @@ struct XenPTRegInfo { uint32_t ro_mask; /* reg emulate field mask (ON:emu, OFF:passthrough) */ uint32_t emu_mask; - /* no write back allowed */ - uint32_t no_wb; xen_pt_conf_reg_init init; /* read/write function pointer * for double_word/word/byte size */ |