diff options
author | M. Mohan Kumar <mohan@in.ibm.com> | 2010-06-09 19:14:38 +0530 |
---|---|---|
committer | Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> | 2010-09-08 22:56:39 +0530 |
commit | 74bc02b2d2272dc88fb98d43e631eb154717f517 (patch) | |
tree | c3aa59eb04e3683a0f758f3728b45791ebe4e5d9 /hw/virtio-9p.c | |
parent | 00ede4c2529b317cf396c02817cadd5ec43953eb (diff) |
virtio-9p: Do not reset atime
Current code resets file's atime to 0 when there is a change in mtime.
This results in resetting the atime to "1970-01-01 05:30:00". For
example, truncate -s 0 filename results in changing the mtime to the
truncate time, but resets the atime to "1970-01-01 05:30:00". utime
system call does not have any provision to set only mtime or atime. So
change v9fs_wstat_post_chmod function to use utimensat function to change
the atime and mtime fields. If tv_nsec field is set to the special value
"UTIME_OMIT", corresponding file time stamp is not updated.
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Signed-off-by: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
Diffstat (limited to 'hw/virtio-9p.c')
-rw-r--r-- | hw/virtio-9p.c | 28 |
1 files changed, 20 insertions, 8 deletions
diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c index a8f1735edb..bd6cba9194 100644 --- a/hw/virtio-9p.c +++ b/hw/virtio-9p.c @@ -237,10 +237,25 @@ static int v9fs_do_chown(V9fsState *s, V9fsString *path, uid_t uid, gid_t gid) return s->ops->chown(&s->ctx, path->data, &cred); } -static int v9fs_do_utime(V9fsState *s, V9fsString *path, - const struct utimbuf *buf) +static int v9fs_do_utimensat(V9fsState *s, V9fsString *path, V9fsStat v9stat) { - return s->ops->utime(&s->ctx, path->data, buf); + struct timespec ts[2]; + + if (v9stat.atime != -1) { + ts[0].tv_sec = v9stat.atime; + ts[0].tv_nsec = 0; + } else { + ts[0].tv_nsec = UTIME_OMIT; + } + + if (v9stat.mtime != -1) { + ts[1].tv_sec = v9stat.mtime; + ts[1].tv_nsec = 0; + } else { + ts[1].tv_nsec = UTIME_OMIT; + } + + return s->ops->utimensat(&s->ctx, path->data, ts); } static int v9fs_do_remove(V9fsState *s, V9fsString *path) @@ -2325,11 +2340,8 @@ static void v9fs_wstat_post_chmod(V9fsState *s, V9fsWstatState *vs, int err) goto out; } - if (vs->v9stat.mtime != -1) { - struct utimbuf tb; - tb.actime = 0; - tb.modtime = vs->v9stat.mtime; - if (v9fs_do_utime(s, &vs->fidp->path, &tb)) { + if (vs->v9stat.mtime != -1 || vs->v9stat.atime != -1) { + if (v9fs_do_utimensat(s, &vs->fidp->path, vs->v9stat)) { err = -errno; } } |