diff options
| author | Markus Armbruster <armbru@redhat.com> | 2019-08-12 07:23:50 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2019-08-16 13:31:52 +0200 |
| commit | db725815985654007ade0fd53590d613fd657208 (patch) | |
| tree | e39bcf77a808fa0002cea415b2a487cf5c7eaf4b /hw/usb | |
| parent | dc5e9ac716c5c5312ab29fb9f311f8176064fe04 (diff) | |
Include qemu/main-loop.h less
In my "build everything" tree, changing qemu/main-loop.h triggers a
recompile of some 5600 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h). It includes block/aio.h,
which in turn includes qemu/event_notifier.h, qemu/notify.h,
qemu/processor.h, qemu/qsp.h, qemu/queue.h, qemu/thread-posix.h,
qemu/thread.h, qemu/timer.h, and a few more.
Include qemu/main-loop.h only where it's needed. Touching it now
recompiles only some 1700 objects. For block/aio.h and
qemu/event_notifier.h, these numbers drop from 5600 to 2800. For the
others, they shrink only slightly.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190812052359.30071-21-armbru@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'hw/usb')
| -rw-r--r-- | hw/usb/dev-uas.c | 1 | ||||
| -rw-r--r-- | hw/usb/hcd-ehci.c | 1 | ||||
| -rw-r--r-- | hw/usb/host-libusb.c | 1 | ||||
| -rw-r--r-- | hw/usb/xen-usb.c | 1 |
4 files changed, 4 insertions, 0 deletions
diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c index 525bc1e590..c7d215d4ef 100644 --- a/hw/usb/dev-uas.c +++ b/hw/usb/dev-uas.c @@ -14,6 +14,7 @@ #include "qemu/config-file.h" #include "trace.h" #include "qemu/error-report.h" +#include "qemu/main-loop.h" #include "qemu/module.h" #include "hw/usb.h" diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 45ff4f4115..d7d1ecd45d 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -34,6 +34,7 @@ #include "migration/vmstate.h" #include "trace.h" #include "qemu/error-report.h" +#include "qemu/main-loop.h" #define FRAME_TIMER_FREQ 1000 #define FRAME_TIMER_NS (NANOSECONDS_PER_SECOND / FRAME_TIMER_FREQ) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 6f5338832a..c043487298 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -43,6 +43,7 @@ #include "migration/vmstate.h" #include "monitor/monitor.h" #include "qemu/error-report.h" +#include "qemu/main-loop.h" #include "qemu/module.h" #include "sysemu/sysemu.h" #include "trace.h" diff --git a/hw/usb/xen-usb.c b/hw/usb/xen-usb.c index dfbb418e77..1fc2f32ce9 100644 --- a/hw/usb/xen-usb.c +++ b/hw/usb/xen-usb.c @@ -24,6 +24,7 @@ #include <sys/user.h> #include "qemu/config-file.h" +#include "qemu/main-loop.h" #include "qemu/option.h" #include "hw/sysbus.h" #include "hw/usb.h" |