aboutsummaryrefslogtreecommitdiff
path: root/hw/usb/dev-mtp.c
diff options
context:
space:
mode:
authorBandan Das <bsd@redhat.com>2019-04-15 12:47:12 -0400
committerGerd Hoffmann <kraxel@redhat.com>2019-05-02 08:29:33 +0200
commit83c44b44d406326117ca2f040bae8d7de97b9c8e (patch)
tree3a5ed2e3048e9c42f88f3dd478307177c9862ee2 /hw/usb/dev-mtp.c
parent1259f27ec2113d34e54ee731aac5990d9606d9fa (diff)
usb-mtp: change default to success for usb_mtp_update_object
Commit c5ead51f90cf (usb-mtp: return incomplete transfer on a lstat failure) checks if lstat succeeded when updating attributes of a file. However, it also changed behavior to return an error by default. This is incorrect because for smaller file sizes, Qemu will attempt to write the file in one go and there won't be an object for it. Fixes: c5ead51f90cf Signed-off-by: Bandan Das <bsd@redhat.com> Message-id: jpgwojv9pwv.fsf@linux.bootlegged.copy Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'hw/usb/dev-mtp.c')
-rw-r--r--hw/usb/dev-mtp.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 963449ec7d..d90b336d53 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -1587,7 +1587,7 @@ done:
static int usb_mtp_update_object(MTPObject *parent, char *name)
{
- int ret = -1;
+ int ret = 0;
MTPObject *o =
usb_mtp_object_lookup_name(parent, name, strlen(name));