diff options
author | Daniel P. Berrange <berrange@redhat.com> | 2015-08-26 12:17:18 +0100 |
---|---|---|
committer | Michael Tokarev <mjt@tls.msk.ru> | 2015-09-11 10:21:38 +0300 |
commit | ef1e1e0782e99c9dcf2b35e5310cdd8ca9211374 (patch) | |
tree | 0b0f9a746055b66019016ed2d8e4ff9df7d79a8c /hw/pci-host/prep.c | |
parent | 4595a48a10e576638795950b61957f83d2ed09b4 (diff) |
maint: avoid useless "if (foo) free(foo)" pattern
The free() and g_free() functions both happily accept
NULL on any platform QEMU builds on. As such putting a
conditional 'if (foo)' check before calls to 'free(foo)'
merely serves to bloat the lines of code.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'hw/pci-host/prep.c')
-rw-r--r-- | hw/pci-host/prep.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c index c63f45d217..988907bfa0 100644 --- a/hw/pci-host/prep.c +++ b/hw/pci-host/prep.c @@ -328,9 +328,7 @@ static void raven_realize(PCIDevice *d, Error **errp) if (bios_size < 0 || bios_size > BIOS_SIZE) { hw_error("qemu: could not load bios image '%s'\n", s->bios_name); } - if (filename) { - g_free(filename); - } + g_free(filename); } } |