aboutsummaryrefslogtreecommitdiff
path: root/hw/net/lance.c
diff options
context:
space:
mode:
authorEugenio Pérez <eperezma@redhat.com>2021-11-04 09:56:25 +0100
committerMichael S. Tsirkin <mst@redhat.com>2021-11-11 03:13:05 -0500
commit14c81b2191fffb61cd6d2a7a839d34ec2d5e09a1 (patch)
tree25896ef1c74eb2e580371d8ac6fad7d043bdfce7 /hw/net/lance.c
parent245cf2c24eb0d5a4fe75151e1794aa5cd53b130d (diff)
vhost: Fix last vq queue index of devices with no cvq
The -1 assumes that cvq device model is accounted in data_queue_pairs, if cvq does not exists, but it's actually the opposite: Devices with !cvq are ok but devices with cvq does not add the last queue to data_queue_pairs. This is not a problem to vhost-net, but it is to vhost-vdpa: * Devices with cvq gets initialized at last data vq device model, not at cvq one. * Devices with !cvq never gets initialized, since last_index is the first queue of the last device model. Because of that, the right change in last_index is to actually add the cvq, not to remove the missing one. This is not a problem to vhost-net, but it is to vhost-vdpa, which device model trust to reach the last index to finish starting the device. Also, as the previous commit, rename it to index_end. Tested with vp_vdpa with host's vhost=on and vhost=off, with ctrl_vq=on and ctrl_vq=off. Fixes: 049eb15b5fc9 ("vhost: record the last virtqueue index for the virtio device") Reviewed-by: Juan Quintela <quintela@redhat.com> Signed-off-by: Eugenio Pérez <eperezma@redhat.com> Message-Id: <20211104085625.2054959-3-eperezma@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw/net/lance.c')
0 files changed, 0 insertions, 0 deletions