diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2013-03-15 14:34:22 +0000 |
|---|---|---|
| committer | Anthony Liguori <aliguori@us.ibm.com> | 2013-04-01 09:08:33 -0500 |
| commit | c34e120554c31d45bdfbac08a5c1d9ef92a62020 (patch) | |
| tree | 243b66a6e204426fcc5e39b8b462080a64b4fbdf /hw/milkymist-hw.h | |
| parent | 20cf850c6ac5bf1ef13de1da93a5c8b5ea28b304 (diff) | |
milkymist-softusb: Don't map RAM memory regions in the device itself
Don't map the pmem and dmem RAM memory regions in the milkymist-softusb
device itself. Instead just expose them as sysbus mmio regions which
the device creator can map appropriately. This allows us to drop the
pmem_base and dmem_base properties. Instead of going via
cpu_physical_memory_read/_write when the device wants to access the
RAMs, we just keep a host pointer to the memory and use that.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Acked-by: Michael Walle <michael@walle.cc>
Message-id: 1363358063-23973-5-git-send-email-peter.maydell@linaro.org
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'hw/milkymist-hw.h')
| -rw-r--r-- | hw/milkymist-hw.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/hw/milkymist-hw.h b/hw/milkymist-hw.h index 8e6c01e623..4e86c4e832 100644 --- a/hw/milkymist-hw.h +++ b/hw/milkymist-hw.h @@ -194,12 +194,12 @@ static inline DeviceState *milkymist_softusb_create(hwaddr base, DeviceState *dev; dev = qdev_create(NULL, "milkymist-softusb"); - qdev_prop_set_uint32(dev, "pmem_base", pmem_base); qdev_prop_set_uint32(dev, "pmem_size", pmem_size); - qdev_prop_set_uint32(dev, "dmem_base", dmem_base); qdev_prop_set_uint32(dev, "dmem_size", dmem_size); qdev_init_nofail(dev); sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, base); + sysbus_mmio_map(SYS_BUS_DEVICE(dev), 1, pmem_base); + sysbus_mmio_map(SYS_BUS_DEVICE(dev), 2, dmem_base); sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, irq); return dev; |