diff options
| author | Markus Armbruster <armbru@redhat.com> | 2019-08-12 07:23:51 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2019-08-16 13:31:53 +0200 |
| commit | a27bd6c779badb8d76e4430d810ef710a1b98f4e (patch) | |
| tree | b7631b26b400537ff383b13e9e9deb299cef85b4 /hw/ipmi | |
| parent | db725815985654007ade0fd53590d613fd657208 (diff) | |
Include hw/qdev-properties.h less
In my "build everything" tree, changing hw/qdev-properties.h triggers
a recompile of some 2700 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h).
Many places including hw/qdev-properties.h (directly or via hw/qdev.h)
actually need only hw/qdev-core.h. Include hw/qdev-core.h there
instead.
hw/qdev.h is actually pointless: all it does is include hw/qdev-core.h
and hw/qdev-properties.h, which in turn includes hw/qdev-core.h.
Replace the remaining uses of hw/qdev.h by hw/qdev-properties.h.
While there, delete a few superfluous inclusions of hw/qdev-core.h.
Touching hw/qdev-properties.h now recompiles some 1200 objects.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20190812052359.30071-22-armbru@redhat.com>
Diffstat (limited to 'hw/ipmi')
| -rw-r--r-- | hw/ipmi/ipmi.c | 1 | ||||
| -rw-r--r-- | hw/ipmi/ipmi_bmc_extern.c | 1 | ||||
| -rw-r--r-- | hw/ipmi/ipmi_bmc_sim.c | 1 | ||||
| -rw-r--r-- | hw/ipmi/isa_ipmi_bt.c | 1 | ||||
| -rw-r--r-- | hw/ipmi/isa_ipmi_kcs.c | 1 |
5 files changed, 5 insertions, 0 deletions
diff --git a/hw/ipmi/ipmi.c b/hw/ipmi/ipmi.c index 2090c6f73a..ff05a889ec 100644 --- a/hw/ipmi/ipmi.c +++ b/hw/ipmi/ipmi.c @@ -24,6 +24,7 @@ #include "qemu/osdep.h" #include "hw/ipmi/ipmi.h" +#include "hw/qdev-properties.h" #include "sysemu/sysemu.h" #include "qom/object_interfaces.h" #include "qapi/error.h" diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c index eb2eba891c..4405aa634e 100644 --- a/hw/ipmi/ipmi_bmc_extern.c +++ b/hw/ipmi/ipmi_bmc_extern.c @@ -35,6 +35,7 @@ #include "chardev/char-fe.h" #include "sysemu/sysemu.h" #include "hw/ipmi/ipmi.h" +#include "hw/qdev-properties.h" #include "migration/vmstate.h" #define VM_MSG_CHAR 0xA0 /* Marks end of message */ diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c index 91e1484103..246a6d390c 100644 --- a/hw/ipmi/ipmi_bmc_sim.c +++ b/hw/ipmi/ipmi_bmc_sim.c @@ -29,6 +29,7 @@ #include "qemu/error-report.h" #include "qemu/module.h" #include "hw/loader.h" +#include "hw/qdev-properties.h" #include "migration/vmstate.h" #define IPMI_NETFN_CHASSIS 0x00 diff --git a/hw/ipmi/isa_ipmi_bt.c b/hw/ipmi/isa_ipmi_bt.c index 33c800acb5..a696096cbb 100644 --- a/hw/ipmi/isa_ipmi_bt.c +++ b/hw/ipmi/isa_ipmi_bt.c @@ -29,6 +29,7 @@ #include "hw/ipmi/ipmi.h" #include "hw/irq.h" #include "hw/isa/isa.h" +#include "hw/qdev-properties.h" #include "migration/vmstate.h" /* Control register */ diff --git a/hw/ipmi/isa_ipmi_kcs.c b/hw/ipmi/isa_ipmi_kcs.c index 9a1de662ba..374b2a0709 100644 --- a/hw/ipmi/isa_ipmi_kcs.c +++ b/hw/ipmi/isa_ipmi_kcs.c @@ -29,6 +29,7 @@ #include "hw/ipmi/ipmi.h" #include "hw/irq.h" #include "hw/isa/isa.h" +#include "hw/qdev-properties.h" #include "migration/vmstate.h" #define IPMI_KCS_OBF_BIT 0 |