diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2014-03-28 15:12:55 +0000 |
|---|---|---|
| committer | Michael Tokarev <mjt@tls.msk.ru> | 2014-04-18 10:33:36 +0400 |
| commit | ee25595f0126de0f83da86cc29ba2365be7a50d2 (patch) | |
| tree | 3ca0ced8c087c66eed997c8c3def0443e1a1b158 /hw/ide | |
| parent | 86e117724a463b865accfd31eed383c2652c3d17 (diff) | |
hw/ide/ahci.c: Avoid shift left into sign bit
Add U suffix to avoid shifting left into the sign bit, which
is undefined behaviour.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'hw/ide')
| -rw-r--r-- | hw/ide/ahci.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index bfe633f3a5..50327ffdf1 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -438,9 +438,9 @@ static void check_cmd(AHCIState *s, int port) if ((pr->cmd & PORT_CMD_START) && pr->cmd_issue) { for (slot = 0; (slot < 32) && pr->cmd_issue; slot++) { - if ((pr->cmd_issue & (1 << slot)) && + if ((pr->cmd_issue & (1U << slot)) && !handle_cmd(s, port, slot)) { - pr->cmd_issue &= ~(1 << slot); + pr->cmd_issue &= ~(1U << slot); } } } |