diff options
author | Markus Armbruster <armbru@redhat.com> | 2013-08-16 15:18:28 +0200 |
---|---|---|
committer | Michael S. Tsirkin <mst@redhat.com> | 2013-09-28 22:40:58 +0300 |
commit | 351a6a73ca7a9123f0dfd6c6f85fd01e82fe3741 (patch) | |
tree | 842a686eecfd3dfb9c88c9880541460cc7b5aba1 /hw/i386/smbios.c | |
parent | 702d66a813dd84afd7c3d1ad8cbdcc8e3449bcd9 (diff) |
smbios: Normalize smbios_entry_add()'s error handling to exit(1)
It exits on all error conditions but one, where it returns -1.
Normalize, and return void.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw/i386/smbios.c')
-rw-r--r-- | hw/i386/smbios.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c index e708cb8919..0608aee3db 100644 --- a/hw/i386/smbios.c +++ b/hw/i386/smbios.c @@ -183,7 +183,7 @@ static void smbios_build_type_1_fields(const char *t) buf, strlen(buf) + 1); } -int smbios_entry_add(const char *t) +void smbios_entry_add(const char *t) { char buf[1024]; @@ -222,7 +222,7 @@ int smbios_entry_add(const char *t) smbios_entries_len += sizeof(*table) + size; (*(uint16_t *)smbios_entries) = cpu_to_le16(le16_to_cpu(*(uint16_t *)smbios_entries) + 1); - return 0; + return; } if (get_param_value(buf, sizeof(buf), "type", t)) { @@ -230,10 +230,10 @@ int smbios_entry_add(const char *t) switch (type) { case 0: smbios_build_type_0_fields(t); - return 0; + return; case 1: smbios_build_type_1_fields(t); - return 0; + return; default: error_report("Don't know how to build fields for SMBIOS type %ld", type); @@ -242,5 +242,5 @@ int smbios_entry_add(const char *t) } error_report("Must specify type= or file="); - return -1; + exit(1); } |