diff options
| author | Corey Minyard <cminyard@mvista.com> | 2018-11-20 11:13:42 -0600 |
|---|---|---|
| committer | Corey Minyard <cminyard@mvista.com> | 2019-02-27 21:06:08 -0600 |
| commit | bc15cde0c4acc9128f26ff78f99ce34a59200d5e (patch) | |
| tree | 7faa1aea444e191365aacec055a9dec8bde235b6 /hw/i2c/exynos4210_i2c.c | |
| parent | 05f9f17e2caf249e9454f43e0c3751b2d06e1c06 (diff) | |
i2c: Don't check return value from i2c_recv()
i2c_recv() cannot fail, so there is no need to check the return
value. It also returns unt8_t, so comparing with < 0 is not
meaningful.
Fix up various I2C controllers to remove the unneeded code.
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'hw/i2c/exynos4210_i2c.c')
| -rw-r--r-- | hw/i2c/exynos4210_i2c.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/hw/i2c/exynos4210_i2c.c b/hw/i2c/exynos4210_i2c.c index c96fa7d7be..d154b05739 100644 --- a/hw/i2c/exynos4210_i2c.c +++ b/hw/i2c/exynos4210_i2c.c @@ -106,16 +106,10 @@ static inline void exynos4210_i2c_raise_interrupt(Exynos4210I2CState *s) static void exynos4210_i2c_data_receive(void *opaque) { Exynos4210I2CState *s = (Exynos4210I2CState *)opaque; - int ret; s->i2cstat &= ~I2CSTAT_LAST_BIT; s->scl_free = false; - ret = i2c_recv(s->bus); - if (ret < 0 && (s->i2ccon & I2CCON_ACK_GEN)) { - s->i2cstat |= I2CSTAT_LAST_BIT; /* Data is not acknowledged */ - } else { - s->i2cds = ret; - } + s->i2cds = i2c_recv(s->bus); exynos4210_i2c_raise_interrupt(s); } |