diff options
| author | Gerd Hoffmann <kraxel@redhat.com> | 2009-08-14 10:36:05 +0200 |
|---|---|---|
| committer | Anthony Liguori <aliguori@us.ibm.com> | 2009-08-27 20:43:28 -0500 |
| commit | 81a322d4a1b68d47908a6630bf22897a289722aa (patch) | |
| tree | cdca9840d0620d9e0b46d7b81c58abe04a372b78 /hw/etraxfs_pic.c | |
| parent | 24e6f3551f3c8ea7cc7524a3e64e84beca59618f (diff) | |
qdev: add return value to init() callbacks.
Sorry folks, but it has to be. One more of these invasive qdev patches.
We have a serious design bug in the qdev interface: device init
callbacks can't signal failure because the init() callback has no
return value. This patch fixes it.
We have already one case in-tree where this is needed:
Try -device virtio-blk-pci (without drive= specified) and watch qemu
segfault. This patch fixes it.
With usb+scsi being converted to qdev we'll get more devices where the
init callback can fail for various reasons.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'hw/etraxfs_pic.c')
| -rw-r--r-- | hw/etraxfs_pic.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/hw/etraxfs_pic.c b/hw/etraxfs_pic.c index 6e063c8be8..b2c4859949 100644 --- a/hw/etraxfs_pic.c +++ b/hw/etraxfs_pic.c @@ -136,7 +136,7 @@ static void irq_handler(void *opaque, int irq, int level) pic_update(fs); } -static void etraxfs_pic_init(SysBusDevice *dev) +static int etraxfs_pic_init(SysBusDevice *dev) { struct etrax_pic *s = FROM_SYSBUS(typeof (*s), dev); int intr_vect_regs; @@ -147,6 +147,7 @@ static void etraxfs_pic_init(SysBusDevice *dev) intr_vect_regs = cpu_register_io_memory(pic_read, pic_write, s); sysbus_init_mmio(dev, R_MAX * 4, intr_vect_regs); + return 0; } static SysBusDeviceInfo etraxfs_pic_info = { |