diff options
| author | Michael S. Tsirkin <mst@redhat.com> | 2011-02-15 18:27:52 +0200 |
|---|---|---|
| committer | Aurelien Jarno <aurelien@aurel32.net> | 2011-02-20 15:18:20 +0100 |
| commit | ee912ccfa007351a62ba42bd60499769f6c02c1e (patch) | |
| tree | 6305a2d2de74ab75e45bd5a912c06d13a7f4e0f1 /hw/e1000.c | |
| parent | b19487e27ed3009df7f555998a454ba19aefd4b8 (diff) | |
e1000: clear EOP for multi-buffer descriptors
The e1000 spec says: if software statically allocates
buffers, and uses memory read to check for completed descriptors, it
simply has to zero the status byte in the descriptor to make it ready
for reuse by hardware. This is not a hardware requirement (moving the
hardware tail pointer is), but is necessary for performing an in–memory
scan.
Thus the guest does not have to clear the status byte. In case it
doesn't we need to clear EOP for all descriptors
except the last. While I don't know of any such guests,
it's probably a good idea to stick to the spec.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reported-by: Juan Quintela <quintela@redhat.com>
Acked-by: Alex Williamson <alex.williamson@redhat.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Diffstat (limited to 'hw/e1000.c')
| -rw-r--r-- | hw/e1000.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/hw/e1000.c b/hw/e1000.c index 050ce0219d..2943a1a375 100644 --- a/hw/e1000.c +++ b/hw/e1000.c @@ -698,11 +698,13 @@ e1000_receive(VLANClientState *nc, const uint8_t *buf, size_t size) copy_size); } desc_offset += desc_size; + desc.length = cpu_to_le16(desc_size); if (desc_offset >= total_size) { - desc.length = cpu_to_le16(desc_size); desc.status |= E1000_RXD_STAT_EOP | E1000_RXD_STAT_IXSM; } else { - desc.length = cpu_to_le16(desc_size); + /* Guest zeroing out status is not a hardware requirement. + Clear EOP in case guest didn't do it. */ + desc.status &= ~E1000_RXD_STAT_EOP; } } else { // as per intel docs; skip descriptors with null buf addr DBGOUT(RX, "Null RX descriptor!!\n"); |