diff options
| author | Jim Meyering <meyering@redhat.com> | 2012-10-04 13:09:56 +0200 |
|---|---|---|
| committer | Anthony Liguori <aliguori@us.ibm.com> | 2012-10-05 07:58:37 -0500 |
| commit | 9238c2099d37748a4e2cbbe709ed1ebffa6f3c8b (patch) | |
| tree | a2a3b8b714380d4c8e6013b795c0a70f157fc48a /hw/9pfs/virtio-9p-xattr.c | |
| parent | e5fda03839e3c61b01d6c60de5625501d01c69d0 (diff) | |
virtio-9p: avoid unwarranted uses of strncpy
In all of these cases, the uses of strncpy were unnecessary, since
at each point of use we know that the NUL-terminated source bytes
fit in the destination buffer. Use memcpy in place of strncpy.
Acked-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Jim Meyering <meyering@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'hw/9pfs/virtio-9p-xattr.c')
| -rw-r--r-- | hw/9pfs/virtio-9p-xattr.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/hw/9pfs/virtio-9p-xattr.c b/hw/9pfs/virtio-9p-xattr.c index 7f08f6e176..a83960676d 100644 --- a/hw/9pfs/virtio-9p-xattr.c +++ b/hw/9pfs/virtio-9p-xattr.c @@ -53,7 +53,8 @@ ssize_t pt_listxattr(FsContext *ctx, const char *path, return -1; } - strncpy(value, name, name_size); + /* no need for strncpy: name_size is strlen(name)+1 */ + memcpy(value, name, name_size); return name_size; } |