diff options
author | Markus Armbruster <armbru@redhat.com> | 2019-04-09 19:40:18 +0200 |
---|---|---|
committer | Alistair Francis <alistair.francis@wdc.com> | 2019-04-09 16:35:40 -0700 |
commit | 065e6298a75164b4347682b63381dbe752c2b156 (patch) | |
tree | be396b9fa2655a5947fcbed48ceb087f86bf2397 /hmp-commands-info.hx | |
parent | f151f8aca5cf5da24f6eb743a55a2233091ae532 (diff) |
device_tree: Fix integer overflowing in load_device_tree()
If the value of get_image_size() exceeds INT_MAX / 2 - 10000, the
computation of @dt_size overflows to a negative number, which then
gets converted to a very large size_t for g_malloc0() and
load_image_size(). In the (fortunately improbable) case g_malloc0()
succeeds and load_image_size() survives, we'd assign the negative
number to *sizep. What that would do to the callers I can't say, but
it's unlikely to be good.
Fix by rejecting images whose size would overflow.
Reported-by: Kurtis Miller <kurtis.miller@nccgroup.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20190409174018.25798-1-armbru@redhat.com>
Diffstat (limited to 'hmp-commands-info.hx')
0 files changed, 0 insertions, 0 deletions