diff options
| author | Max Filippov <jcmvbkbc@gmail.com> | 2013-09-27 22:29:17 +0400 |
|---|---|---|
| committer | Max Filippov <jcmvbkbc@gmail.com> | 2013-11-08 09:25:22 +0400 |
| commit | e8262a1b5b7cfbcbc80c46e4ce6ff7c517b7b2f6 (patch) | |
| tree | 23ba0aed94e2d3eaf2c77dec1f435a09dfcb85de /exec.c | |
| parent | 964668b03d26f0b5baa5e5aff0c966f4fcb76e9e (diff) | |
exec: fix breakpoint_invalidate when pc may not be translated
This fixes qemu abort with the following message:
include/qemu/int128.h:22: int128_get64: Assertion `!a.hi' failed.
which happens due to attempt to invalidate breakpoint by virtual address
for which get_phys_page_debug couldn't find mapping.
For more details see
http://lists.nongnu.org/archive/html/qemu-devel/2013-09/msg04582.html
Cc: qemu-stable@nongnu.org
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'exec.c')
| -rw-r--r-- | exec.c | 6 |
1 files changed, 4 insertions, 2 deletions
@@ -409,8 +409,10 @@ static void breakpoint_invalidate(CPUState *cpu, target_ulong pc) #else static void breakpoint_invalidate(CPUState *cpu, target_ulong pc) { - tb_invalidate_phys_addr(cpu_get_phys_page_debug(cpu, pc) | - (pc & ~TARGET_PAGE_MASK)); + hwaddr phys = cpu_get_phys_page_debug(cpu, pc); + if (phys != -1) { + tb_invalidate_phys_addr(phys | (pc & ~TARGET_PAGE_MASK)); + } } #endif #endif /* TARGET_HAS_ICE */ |