aboutsummaryrefslogtreecommitdiff
path: root/docs
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2023-08-25 17:59:22 +0200
committerMichael Tokarev <mjt@tls.msk.ru>2023-09-08 13:08:52 +0300
commitb21a6e31a182a5ae7436a444f840d49aac07c94f (patch)
tree5b79e35e258daab467f55f7c8f338257dfe5d829 /docs
parentbcd8e243083c878884e52d609deddbe6be17c730 (diff)
docs tests: Fix use of migrate_set_parameter
docs/multi-thread-compression.txt uses parameter names with underscores instead of dashes. Wrong since day one. docs/rdma.txt, tests/qemu-iotests/181, and tests/qtest/test-hmp.c are wrong the same way since commit cbde7be900d2 (v6.0.0). Hard to see, as test-hmp doesn't check whether the commands work, and iotest 181 appears to be unaffected. Fixes: 263170e679df (docs: Add a doc about multiple thread compression) Fixes: cbde7be900d2 (migrate: remove QMP/HMP commands for speed, downtime and cache size) Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Thomas Huth <thuth@redhat.com> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'docs')
-rw-r--r--docs/multi-thread-compression.txt12
-rw-r--r--docs/rdma.txt2
2 files changed, 7 insertions, 7 deletions
diff --git a/docs/multi-thread-compression.txt b/docs/multi-thread-compression.txt
index bb88c6bdf1..95b1556f67 100644
--- a/docs/multi-thread-compression.txt
+++ b/docs/multi-thread-compression.txt
@@ -117,13 +117,13 @@ to support the multiple thread compression migration:
{qemu} migrate_set_capability compress on
3. Set the compression thread count on source:
- {qemu} migrate_set_parameter compress_threads 12
+ {qemu} migrate_set_parameter compress-threads 12
4. Set the compression level on the source:
- {qemu} migrate_set_parameter compress_level 1
+ {qemu} migrate_set_parameter compress-level 1
5. Set the decompression thread count on destination:
- {qemu} migrate_set_parameter decompress_threads 3
+ {qemu} migrate_set_parameter decompress-threads 3
6. Start outgoing migration:
{qemu} migrate -d tcp:destination.host:4444
@@ -133,9 +133,9 @@ to support the multiple thread compression migration:
The following are the default settings:
compress: off
- compress_threads: 8
- decompress_threads: 2
- compress_level: 1 (which means best speed)
+ compress-threads: 8
+ decompress-threads: 2
+ compress-level: 1 (which means best speed)
So, only the first two steps are required to use the multiple
thread compression in migration. You can do more if the default
diff --git a/docs/rdma.txt b/docs/rdma.txt
index 2b4cdea1d8..bd8dd799a9 100644
--- a/docs/rdma.txt
+++ b/docs/rdma.txt
@@ -89,7 +89,7 @@ RUNNING:
First, set the migration speed to match your hardware's capabilities:
QEMU Monitor Command:
-$ migrate_set_parameter max_bandwidth 40g # or whatever is the MAX of your RDMA device
+$ migrate_set_parameter max-bandwidth 40g # or whatever is the MAX of your RDMA device
Next, on the destination machine, add the following to the QEMU command line: