diff options
author | Kevin Wolf <kwolf@redhat.com> | 2018-08-17 14:58:49 +0200 |
---|---|---|
committer | Kevin Wolf <kwolf@redhat.com> | 2018-09-25 15:50:15 +0200 |
commit | 4cf077b59fc73eec29f8b7d082919dbb278bdc86 (patch) | |
tree | 70cc462429b98e283714581c87e62484c86db01a /device-hotplug.c | |
parent | b5a7a0573530698ee448b063ac01d485e30446bd (diff) |
block: Remove aio_poll() in bdrv_drain_poll variants
bdrv_drain_poll_top_level() was buggy because it didn't release the
AioContext lock of the node to be drained before calling aio_poll().
This way, callbacks called by aio_poll() would possibly take the lock a
second time and run into a deadlock with a nested AIO_WAIT_WHILE() call.
However, it turns out that the aio_poll() call isn't actually needed any
more. It was introduced in commit 91af091f923, which is effectively
reverted by this patch. The cases it was supposed to fix are now covered
by bdrv_drain_poll(), which waits for block jobs to reach a quiescent
state.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'device-hotplug.c')
0 files changed, 0 insertions, 0 deletions