diff options
author | Markus Armbruster <armbru@redhat.com> | 2012-06-29 17:34:23 +0200 |
---|---|---|
committer | Kevin Wolf <kwolf@redhat.com> | 2012-07-09 15:53:03 +0200 |
commit | 1f69c2b022710222ff0379678e49f8bfb6c91233 (patch) | |
tree | 2bacd730b0a805215b2315937accd465d04762a0 /def-helper.h | |
parent | b3ce604eeaa77970fa53838e7df2bc85344f2554 (diff) |
fdc: Drop broken code for user-defined floppy geometry
bdrv_get_floppy_geometry_hint() fails to store through its parameter
drive when bs has a geometry hint. Makes fd_revalidate() assign
random crap to drv->drive.
Has been broken that way for ages. Harmless, because:
* The only way to set a geometry hint is -drive if=none,cyls=...
Since commit c219331e, probably unintentional.
* The only use of drv->drive is as argument to another
bdrv_get_floppy_geometry_hint(). Which doesn't use it, since the
geometry hint is still there.
Drop the broken code, ignore -drive parameter cyls, heads and secs for
floppies even with if=none, just like before commit c219331e. Matches
-help, which explains cyls, heads, secs as "hard disk physical
geometry".
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'def-helper.h')
0 files changed, 0 insertions, 0 deletions