diff options
| author | Markus Armbruster <armbru@redhat.com> | 2019-08-12 07:23:50 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2019-08-16 13:31:52 +0200 |
| commit | db725815985654007ade0fd53590d613fd657208 (patch) | |
| tree | e39bcf77a808fa0002cea415b2a487cf5c7eaf4b /chardev | |
| parent | dc5e9ac716c5c5312ab29fb9f311f8176064fe04 (diff) | |
Include qemu/main-loop.h less
In my "build everything" tree, changing qemu/main-loop.h triggers a
recompile of some 5600 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h). It includes block/aio.h,
which in turn includes qemu/event_notifier.h, qemu/notify.h,
qemu/processor.h, qemu/qsp.h, qemu/queue.h, qemu/thread-posix.h,
qemu/thread.h, qemu/timer.h, and a few more.
Include qemu/main-loop.h only where it's needed. Touching it now
recompiles only some 1700 objects. For block/aio.h and
qemu/event_notifier.h, these numbers drop from 5600 to 2800. For the
others, they shrink only slightly.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190812052359.30071-21-armbru@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'chardev')
| -rw-r--r-- | chardev/baum.c | 1 | ||||
| -rw-r--r-- | chardev/char-pipe.c | 1 | ||||
| -rw-r--r-- | chardev/char-win-stdio.c | 1 | ||||
| -rw-r--r-- | chardev/char-win.c | 1 |
4 files changed, 4 insertions, 0 deletions
diff --git a/chardev/baum.c b/chardev/baum.c index 3dc81d5c6c..9c95e7bc79 100644 --- a/chardev/baum.c +++ b/chardev/baum.c @@ -25,6 +25,7 @@ #include "qemu/osdep.h" #include "qapi/error.h" #include "chardev/char.h" +#include "qemu/main-loop.h" #include "qemu/module.h" #include "qemu/timer.h" #include "hw/usb.h" diff --git a/chardev/char-pipe.c b/chardev/char-pipe.c index b200f9365c..94d714ffcd 100644 --- a/chardev/char-pipe.c +++ b/chardev/char-pipe.c @@ -25,6 +25,7 @@ #include "qemu/osdep.h" #include "qemu-common.h" #include "qapi/error.h" +#include "qemu/main-loop.h" #include "qemu/module.h" #include "qemu/option.h" #include "chardev/char.h" diff --git a/chardev/char-win-stdio.c b/chardev/char-win-stdio.c index 92d34e85aa..99afda353c 100644 --- a/chardev/char-win-stdio.c +++ b/chardev/char-win-stdio.c @@ -24,6 +24,7 @@ #include "qemu/osdep.h" #include "qapi/error.h" +#include "qemu/main-loop.h" #include "qemu/module.h" #include "chardev/char-win.h" #include "chardev/char-win-stdio.h" diff --git a/chardev/char-win.c b/chardev/char-win.c index 0b8181339d..34825f683d 100644 --- a/chardev/char-win.c +++ b/chardev/char-win.c @@ -23,6 +23,7 @@ */ #include "qemu/osdep.h" +#include "qemu/main-loop.h" #include "qemu/module.h" #include "qapi/error.h" #include "chardev/char-win.h" |