diff options
| author | Alex Bennée <alex.bennee@linaro.org> | 2023-12-11 09:13:41 +0000 |
|---|---|---|
| committer | Alex Bennée <alex.bennee@linaro.org> | 2024-01-08 13:58:59 +0000 |
| commit | 7b571ef3c75ac35522c817219cbfa765753a36c5 (patch) | |
| tree | 5c968fa259d16a3ef2b62251456eb675d43ad94a /chardev | |
| parent | 1f881ea4a444ef36a8b6907b0b82be4b3af253a2 (diff) | |
chardev: force write all when recording replay logs
This is mostly a problem within avocado as serial generally isn't busy
enough to overfill pipes. However the consequences of recording a
failed write will haunt us on replay when the log will be out of sync
to the playback.
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/2010
Acked-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20231211091346.14616-13-alex.bennee@linaro.org>
Diffstat (limited to 'chardev')
| -rw-r--r-- | chardev/char.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/chardev/char.c b/chardev/char.c index 996a024c7a..48f28881c2 100644 --- a/chardev/char.c +++ b/chardev/char.c @@ -171,6 +171,18 @@ int qemu_chr_write(Chardev *s, const uint8_t *buf, int len, bool write_all) return res; } + if (replay_mode == REPLAY_MODE_RECORD) { + /* + * When recording we don't want temporary conditions to + * perturb the result. By ensuring we write everything we can + * while recording we avoid playback being out of sync if it + * doesn't encounter the same temporary conditions (usually + * triggered by external programs not reading the chardev fast + * enough and pipes filling up). + */ + write_all = true; + } + res = qemu_chr_write_buffer(s, buf, len, &offset, write_all); if (qemu_chr_replay(s) && replay_mode == REPLAY_MODE_RECORD) { |