diff options
| author | John Snow <jsnow@redhat.com> | 2018-10-29 16:23:16 -0400 |
|---|---|---|
| committer | John Snow <jsnow@redhat.com> | 2018-10-29 16:23:16 -0400 |
| commit | b27a6b8b329a8dcbab9dc1af45586f7585f3d47b (patch) | |
| tree | 5ebb2c623155101f94fe5ec57c769642a53370a9 /blockdev.c | |
| parent | b053bb55738f35832f3d6472b12277a75c32a038 (diff) | |
block/backup: prohibit backup from using in use bitmaps
If the bitmap is frozen, we shouldn't touch it.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-id: 20181002230218.13949-6-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
Diffstat (limited to 'blockdev.c')
| -rw-r--r-- | blockdev.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/blockdev.c b/blockdev.c index 35097b92cc..c30495d035 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3513,10 +3513,10 @@ static BlockJob *do_drive_backup(DriveBackup *backup, JobTxn *txn, bdrv_unref(target_bs); goto out; } - if (bdrv_dirty_bitmap_qmp_locked(bmap)) { + if (bdrv_dirty_bitmap_user_locked(bmap)) { error_setg(errp, - "Bitmap '%s' is currently locked and cannot be used for " - "backup", backup->bitmap); + "Bitmap '%s' is currently in use by another operation" + " and cannot be used for backup", backup->bitmap); goto out; } } @@ -3621,10 +3621,10 @@ BlockJob *do_blockdev_backup(BlockdevBackup *backup, JobTxn *txn, error_setg(errp, "Bitmap '%s' could not be found", backup->bitmap); goto out; } - if (bdrv_dirty_bitmap_qmp_locked(bmap)) { + if (bdrv_dirty_bitmap_user_locked(bmap)) { error_setg(errp, - "Bitmap '%s' is currently locked and cannot be used for " - "backup", backup->bitmap); + "Bitmap '%s' is currently in use by another operation" + " and cannot be used for backup", backup->bitmap); goto out; } } |