diff options
| author | Paolo Bonzini <pbonzini@redhat.com> | 2017-05-08 16:13:05 +0200 |
|---|---|---|
| committer | Jeff Cody <jcody@redhat.com> | 2017-05-24 16:38:51 -0400 |
| commit | 2caf63a9039f245ef778833dfc87f0c58adba47b (patch) | |
| tree | aa9cd1d74fb4b8fa7129e591052d1db50ed18efa /blockdev.c | |
| parent | 88691b37f86250647816d77e8e1f0933557e7df5 (diff) | |
blockjob: move iostatus reset inside block_job_user_resume
Outside blockjob.c, the block_job_iostatus_reset function is used once
in the monitor and once in BlockBackend. When we introduce the block
job mutex, block_job_iostatus_reset's client is going to be the block
layer (for which blockjob.c will take the block job mutex) rather than
the monitor (which will take the block job mutex by itself).
The monitor's call to block_job_iostatus_reset from the monitor comes
just before the sole call to block_job_user_resume, so reset the
iostatus directly from block_job_iostatus_reset. This will avoid
the need to introduce separate block_job_iostatus_reset and
block_job_iostatus_reset_locked APIs.
After making this change, move the function together with the others
that were moved in the previous patch.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Message-id: 20170508141310.8674-7-pbonzini@redhat.com
Signed-off-by: Jeff Cody <jcody@redhat.com>
Diffstat (limited to 'blockdev.c')
| -rw-r--r-- | blockdev.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/blockdev.c b/blockdev.c index c63f4e82c7..892d768574 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3715,7 +3715,6 @@ void qmp_block_job_resume(const char *device, Error **errp) } trace_qmp_block_job_resume(job); - block_job_iostatus_reset(job); block_job_user_resume(job); aio_context_release(aio_context); } |