diff options
| author | Markus Armbruster <armbru@redhat.com> | 2019-08-12 07:23:50 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2019-08-16 13:31:52 +0200 |
| commit | db725815985654007ade0fd53590d613fd657208 (patch) | |
| tree | e39bcf77a808fa0002cea415b2a487cf5c7eaf4b /block | |
| parent | dc5e9ac716c5c5312ab29fb9f311f8176064fe04 (diff) | |
Include qemu/main-loop.h less
In my "build everything" tree, changing qemu/main-loop.h triggers a
recompile of some 5600 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h). It includes block/aio.h,
which in turn includes qemu/event_notifier.h, qemu/notify.h,
qemu/processor.h, qemu/qsp.h, qemu/queue.h, qemu/thread-posix.h,
qemu/thread.h, qemu/timer.h, and a few more.
Include qemu/main-loop.h only where it's needed. Touching it now
recompiles only some 1700 objects. For block/aio.h and
qemu/event_notifier.h, these numbers drop from 5600 to 2800. For the
others, they shrink only slightly.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190812052359.30071-21-armbru@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'block')
| -rw-r--r-- | block/block-backend.c | 1 | ||||
| -rw-r--r-- | block/create.c | 1 | ||||
| -rw-r--r-- | block/io.c | 1 | ||||
| -rw-r--r-- | block/nbd.c | 1 | ||||
| -rw-r--r-- | block/nfs.c | 1 | ||||
| -rw-r--r-- | block/nvme.c | 1 | ||||
| -rw-r--r-- | block/qcow2.c | 1 | ||||
| -rw-r--r-- | block/qed.c | 1 | ||||
| -rw-r--r-- | block/sheepdog.c | 1 | ||||
| -rw-r--r-- | block/throttle-groups.c | 1 |
10 files changed, 10 insertions, 0 deletions
diff --git a/block/block-backend.c b/block/block-backend.c index 6aed80bf0b..4991ab5574 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@ -21,6 +21,7 @@ #include "qapi/error.h" #include "qapi/qapi-events-block.h" #include "qemu/id.h" +#include "qemu/main-loop.h" #include "qemu/option.h" #include "trace.h" #include "migration/misc.h" diff --git a/block/create.c b/block/create.c index 95341219ef..1bd00ed5f8 100644 --- a/block/create.c +++ b/block/create.c @@ -25,6 +25,7 @@ #include "qemu/osdep.h" #include "block/block_int.h" #include "qemu/job.h" +#include "qemu/main-loop.h" #include "qapi/qapi-commands-block-core.h" #include "qapi/qapi-visit-block-core.h" #include "qapi/clone-visitor.h" diff --git a/block/io.c b/block/io.c index 06305c6ea6..17a243cde9 100644 --- a/block/io.c +++ b/block/io.c @@ -32,6 +32,7 @@ #include "qemu/cutils.h" #include "qapi/error.h" #include "qemu/error-report.h" +#include "qemu/main-loop.h" #define NOT_DONE 0x7fffffff /* used while emulated sync operation in progress */ diff --git a/block/nbd.c b/block/nbd.c index 57c1a20581..56b1c6ec74 100644 --- a/block/nbd.c +++ b/block/nbd.c @@ -33,6 +33,7 @@ #include "qemu/uri.h" #include "qemu/option.h" #include "qemu/cutils.h" +#include "qemu/main-loop.h" #include "qapi/qapi-visit-sockets.h" #include "qapi/qmp/qstring.h" diff --git a/block/nfs.c b/block/nfs.c index d93241b3bb..a1fe004c61 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -32,6 +32,7 @@ #include "block/qdict.h" #include "trace.h" #include "qemu/iov.h" +#include "qemu/main-loop.h" #include "qemu/module.h" #include "qemu/option.h" #include "qemu/uri.h" diff --git a/block/nvme.c b/block/nvme.c index 2c85713519..5be3a39b63 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -17,6 +17,7 @@ #include "qapi/qmp/qdict.h" #include "qapi/qmp/qstring.h" #include "qemu/error-report.h" +#include "qemu/main-loop.h" #include "qemu/module.h" #include "qemu/cutils.h" #include "qemu/option.h" diff --git a/block/qcow2.c b/block/qcow2.c index 039bdc2f7e..59cff1d4cb 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -26,6 +26,7 @@ #include "block/qdict.h" #include "sysemu/block-backend.h" +#include "qemu/main-loop.h" #include "qemu/module.h" #include "qcow2.h" #include "qemu/error-report.h" diff --git a/block/qed.c b/block/qed.c index 77c7cef175..d0dcc5f14d 100644 --- a/block/qed.c +++ b/block/qed.c @@ -17,6 +17,7 @@ #include "qapi/error.h" #include "qemu/timer.h" #include "qemu/bswap.h" +#include "qemu/main-loop.h" #include "qemu/module.h" #include "qemu/option.h" #include "trace.h" diff --git a/block/sheepdog.c b/block/sheepdog.c index 6f402e5d4d..31b0a820c2 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -22,6 +22,7 @@ #include "qapi/qobject-output-visitor.h" #include "qemu/uri.h" #include "qemu/error-report.h" +#include "qemu/main-loop.h" #include "qemu/module.h" #include "qemu/option.h" #include "qemu/sockets.h" diff --git a/block/throttle-groups.c b/block/throttle-groups.c index a5a2037924..77014c741b 100644 --- a/block/throttle-groups.c +++ b/block/throttle-groups.c @@ -26,6 +26,7 @@ #include "sysemu/block-backend.h" #include "block/throttle-groups.h" #include "qemu/throttle-options.h" +#include "qemu/main-loop.h" #include "qemu/queue.h" #include "qemu/thread.h" #include "sysemu/qtest.h" |