aboutsummaryrefslogtreecommitdiff
path: root/block
diff options
context:
space:
mode:
authorMichael S. Tsirkin <mst@redhat.com>2019-06-21 00:12:22 -0400
committerMichael S. Tsirkin <mst@redhat.com>2019-07-01 09:17:30 -0400
commit2841ab435bca9f102311e01bf157d5fa878935dc (patch)
treec342017afce4eb2b95e6594c426d5acbe8ae1e87 /block
parent861dc73518a049887b709f031359713e5f6b284e (diff)
pcie: check that slt ctrl changed before deleting
During boot, linux would sometimes overwrites control of a powered off slot before powering it on. Unfortunately QEMU interprets that as a power off request and ejects the device. For example: /x86_64-softmmu/qemu-system-x86_64 -enable-kvm -S -machine q35 \ -device pcie-root-port,id=pcie_root_port_0,slot=2,chassis=2,addr=0x2,bus=pcie.0 \ -monitor stdio disk.qcow2 (qemu)device_add virtio-balloon-pci,id=balloon,bus=pcie_root_port_0 (qemu)cont Balloon is deleted during guest boot. To fix, save control beforehand and check that power or led state actually change before ejecting. Note: this is more a hack than a solution, ideally we'd find a better way to detect ejects, or move away from ejects completely and instead monitor whether it's safe to delete device due to e.g. its power state. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> Tested-by: Igor Mammedov <imammedo@redhat.com>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions