diff options
| author | John Snow <jsnow@redhat.com> | 2018-08-29 21:57:27 -0400 |
|---|---|---|
| committer | Max Reitz <mreitz@redhat.com> | 2018-08-31 16:28:33 +0200 |
| commit | 3d1f8b07a4c241f81949eff507d9f3a8fd73b87b (patch) | |
| tree | 7331c18b0a63be6b97cb783320d9cbff485f7f14 /block/commit.c | |
| parent | f67432a2019caf05b57a146bf45c1024a5cb608e (diff) | |
jobs: canonize Error object
Jobs presently use both an Error object in the case of the create job,
and char strings in the case of generic errors elsewhere.
Unify the two paths as just j->err, and remove the extra argument from
job_completed. The integer error code for job_completed is kept for now,
to be removed shortly in a separate patch.
Signed-off-by: John Snow <jsnow@redhat.com>
Message-id: 20180830015734.19765-3-jsnow@redhat.com
[mreitz: Dropped a superfluous g_strdup()]
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'block/commit.c')
| -rw-r--r-- | block/commit.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/block/commit.c b/block/commit.c index a0ea86ff64..4a17bb73ec 100644 --- a/block/commit.c +++ b/block/commit.c @@ -117,7 +117,7 @@ static void commit_complete(Job *job, void *opaque) * bdrv_set_backing_hd() to fail. */ block_job_remove_all_bdrv(bjob); - job_completed(job, ret, NULL); + job_completed(job, ret); g_free(data); /* If bdrv_drop_intermediate() didn't already do that, remove the commit |