diff options
author | Kevin Wolf <kwolf@redhat.com> | 2018-05-16 13:46:37 +0200 |
---|---|---|
committer | Kevin Wolf <kwolf@redhat.com> | 2018-05-23 14:30:51 +0200 |
commit | b3b5299d58bce4366c647af40374e6b063f371eb (patch) | |
tree | 75b11daff436035b154a25cbb4fb61908c47ca44 /block.c | |
parent | 3d70ff53b6bf90d9eec6f97024ec9895f6799d9e (diff) |
block: Cancel job in bdrv_close_all() callers
Now that we cancel all jobs and not only block jobs on shutdown, doing
that in bdrv_close_all() isn't really appropriate any more. Move the
job_cancel_sync_all() call to the callers, and only assert that there
are no job running in bdrv_close_all().
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block.c')
-rw-r--r-- | block.c | 4 |
1 files changed, 1 insertions, 3 deletions
@@ -3362,9 +3362,7 @@ static void bdrv_close(BlockDriverState *bs) void bdrv_close_all(void) { - /* TODO We do want to cancel all jobs instead of just block jobs on - * shutdown, but bdrv_close_all() isn't the right place any more. */ - job_cancel_sync_all(); + assert(job_next(NULL) == NULL); nbd_export_close_all(); /* Drop references from requests still in flight, such as canceled block |