aboutsummaryrefslogtreecommitdiff
path: root/backends
diff options
context:
space:
mode:
authorZhao Liu <zhao1.liu@intel.com>2024-07-15 16:21:55 +0800
committerMichael Tokarev <mjt@tls.msk.ru>2024-07-17 14:04:15 +0300
commit18f3a07b206b228b041c260d48df393111c8299b (patch)
tree6bb0bbff545d90217fc500ec7c9c9c798a410b02 /backends
parent47cd2f1a360196beb9769a2636ccdd3ae9d0370f (diff)
backends/rng-random: Get rid of qemu_open_old()
For qemu_open_old(), osdep.h said: > Don't introduce new usage of this function, prefer the following > qemu_open/qemu_create that take an "Error **errp". So replace qemu_open_old() with qemu_open(). And considering rng_random_opened() will lose its obvious error handling case after removing error_setg_file_open(), add comment to remind here. Cc: Laurent Vivier <lvivier@redhat.com> Cc: Amit Shah <amit@kernel.org> Signed-off-by: Zhao Liu <zhao1.liu@intel.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Michael Tokarev <mjt@tls.msk.ru> (mjt: drop superfluous commit as suggested by philmd) Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'backends')
-rw-r--r--backends/rng-random.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/backends/rng-random.c b/backends/rng-random.c
index 80eb5be138..489c0917f0 100644
--- a/backends/rng-random.c
+++ b/backends/rng-random.c
@@ -75,10 +75,7 @@ static void rng_random_opened(RngBackend *b, Error **errp)
error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
"filename", "a valid filename");
} else {
- s->fd = qemu_open_old(s->filename, O_RDONLY | O_NONBLOCK);
- if (s->fd == -1) {
- error_setg_file_open(errp, errno, s->filename);
- }
+ s->fd = qemu_open(s->filename, O_RDONLY | O_NONBLOCK, errp);
}
}