aboutsummaryrefslogtreecommitdiff
path: root/audio/spiceaudio.c
diff options
context:
space:
mode:
authorMax Reitz <mreitz@redhat.com>2018-05-02 22:20:49 +0200
committerMax Reitz <mreitz@redhat.com>2018-05-15 16:15:21 +0200
commit2a01c01f9ecb43af4c0a85fe6adc429ffc9c31b5 (patch)
tree2aaca0e99235fb30ed1bfc1025895e747bf60bcc /audio/spiceaudio.c
parentc1e3489dfaa01d215e37b1412759b856c33d44ed (diff)
qemu-io: Use purely string blockdev options
Currently, qemu-io only uses string-valued blockdev options (as all are converted directly from QemuOpts) -- with one exception: -U adds the force-share option as a boolean. This in itself is already a bit questionable, but a real issue is that it also assumes the value already existing in the options QDict would be a boolean, which is wrong. That has the following effect: $ ./qemu-io -r -U --image-opts \ driver=file,filename=/dev/null,force-share=off [1] 15200 segmentation fault (core dumped) ./qemu-io -r -U --image-opts driver=file,filename=/dev/null,force-share=off Since @opts is converted from QemuOpts, the value must be a string, and we have to compare it as such. Consequently, it makes sense to also set it as a string instead of a boolean. Cc: qemu-stable@nongnu.org Signed-off-by: Max Reitz <mreitz@redhat.com> Message-id: 20180502202051.15493-2-mreitz@redhat.com Reviewed-by: Eric Blake <eblake@redhat.com> Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'audio/spiceaudio.c')
0 files changed, 0 insertions, 0 deletions