diff options
| author | Markus Armbruster <armbru@redhat.com> | 2015-12-18 16:35:14 +0100 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2016-01-13 15:16:17 +0100 |
| commit | c29b77f955ff2f7b57c1e71e9dc26243eefd0b28 (patch) | |
| tree | c76f9b9338d5a1cefef00917260242c4d04285c5 /arch_init.c | |
| parent | 8aa802a6b768e811e492c7404a58c52ecfb382ed (diff) | |
error: Use error_reportf_err() where it makes obvious sense
Done with this Coccinelle semantic patch
@@
expression FMT, E, S;
expression list ARGS;
@@
- error_report(FMT, ARGS, error_get_pretty(E));
+ error_reportf_err(E, FMT/*@@@*/, ARGS);
(
- error_free(E);
|
exit(S);
|
abort();
)
followed by a replace of '%s"/*@@@*/' by '"' and some line rewrapping,
because I can't figure out how to make Coccinelle transform strings.
We now use the error whole instead of just its message obtained with
error_get_pretty(). This avoids suppressing its hint (see commit
50b7b00), but I can't see how the errors touched in this commit could
come with hints.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1450452927-8346-12-git-send-email-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'arch_init.c')
| -rw-r--r-- | arch_init.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/arch_init.c b/arch_init.c index 38f5fb9c22..d1383b3c43 100644 --- a/arch_init.c +++ b/arch_init.c @@ -258,9 +258,7 @@ void do_acpitable_option(const QemuOpts *opts) acpi_table_add(opts, &err); if (err) { - error_report("Wrong acpi table provided: %s", - error_get_pretty(err)); - error_free(err); + error_reportf_err(err, "Wrong acpi table provided: "); exit(1); } #endif |