aboutsummaryrefslogtreecommitdiff
path: root/HACKING
diff options
context:
space:
mode:
authorCorey Minyard <cminyard@mvista.com>2016-12-22 08:22:11 -0600
committerCorey Minyard <cminyard@mvista.com>2018-01-30 15:52:53 -0600
commitc9c47229145e82ab7a0f27838fd74738d71fed8e (patch)
tree25e4bb0ddaa17643e878869e26f79a8ad5f6eda8 /HACKING
parent9380d2ed22a5f3fa29ddf8ca4cea9bbdc88fed11 (diff)
ipmi: Fix macro issues
Macro parameters should almost always have () around them when used. llvm reported an error on this. Remove redundant parenthesis and put parenthesis around the entire macros with assignments in case they are used in an expression. The macros were doing ((v) & 1) for a binary input, but that only works if v == 0 or if v & 1. Changed to !!(v) so they work for all values. Remove some unused macros. Reported in https://bugs.launchpad.net/bugs/1651167 An audit of these changes found no semantic changes; this is just cleanups for proper style and to avoid a compiler warning. Signed-off-by: Corey Minyard <cminyard@mvista.com> Reviewed-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'HACKING')
0 files changed, 0 insertions, 0 deletions