aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlex Williamson <alex.williamson@redhat.com>2013-03-14 16:01:35 -0600
committerMichael S. Tsirkin <mst@redhat.com>2013-03-26 21:02:18 +0200
commiteb28cb1bb0cb156aef7e613395af403bba0e7f30 (patch)
tree05aaa53dab88b87b89566679072c90b909262bf8
parent0889464a5050c25611d08ca33d8447796c88c7f7 (diff)
pcie: Mangle types to match topology
Windows will fail to start drivers for devices with an Endpoint type PCIe capability attached to a Root Complex (code 10 - Device cannot start). The proper type for such a device is Root Complex Integrated Endpoint. Devices don't care which they are, so do this conversion automatically. This allows the Windows driver to load for nec-usb-xhci when attached to pcie.0 of a q35 machine. Signed-off-by: Alex Williamson <alex.williamson@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
-rw-r--r--hw/pci/pcie.c13
1 files changed, 13 insertions, 0 deletions
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 485c94c1b2..bcfbae4332 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -48,6 +48,19 @@ int pcie_cap_init(PCIDevice *dev, uint8_t offset, uint8_t type, uint8_t port)
assert(pci_is_express(dev));
+ /*
+ * Mangle type to convert Endpoints to Root Complex Integrated Endpoints.
+ * Windows will report Code 10 (device cannot start) for regular Endpoints
+ * on the Root Complex.
+ */
+ if (pci_bus_is_express(dev->bus) && pci_bus_is_root(dev->bus)) {
+ switch (type) {
+ case PCI_EXP_TYPE_ENDPOINT:
+ type = PCI_EXP_TYPE_RC_END;
+ break;
+ }
+ }
+
pos = pci_add_capability(dev, PCI_CAP_ID_EXP, offset,
PCI_EXP_VER2_SIZEOF);
if (pos < 0) {