diff options
| author | Mark Nelson <mdnelson8@gmail.com> | 2021-07-09 07:06:00 -0500 |
|---|---|---|
| committer | Laurent Vivier <laurent@vivier.eu> | 2021-07-09 18:42:46 +0200 |
| commit | e28ffe90fde5702aa8716ac2fa1b4116cdcc9e61 (patch) | |
| tree | 10b11e3863ebc07d9aa9f7183cf2d7faaf162d13 | |
| parent | 179a808045f16e5d9fee06510f0b5ca5ff0c69e8 (diff) | |
util/guest-random: Fix size arg to tail memcpy
We know that in the body of this if statement i is less than len, so
we really should be copying len - i bytes not i - len bytes.
Fix this typo.
Fixes: 8d8404f1564 ("util: Add qemu_guest_getrandom and associated routines")
Signed-off-by: Mark Nelson <mdnelson8@gmail.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210709120600.11080-1-mdnelson8@gmail.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
| -rw-r--r-- | util/guest-random.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/util/guest-random.c b/util/guest-random.c index 086115bd67..23643f86cc 100644 --- a/util/guest-random.c +++ b/util/guest-random.c @@ -38,7 +38,7 @@ static int glib_random_bytes(void *buf, size_t len) } if (i < len) { x = g_rand_int(rand); - __builtin_memcpy(buf + i, &x, i - len); + __builtin_memcpy(buf + i, &x, len - i); } return 0; } |