diff options
| author | Zhenzhong Duan <zhenzhong.duan@intel.com> | 2023-10-09 10:20:46 +0800 |
|---|---|---|
| committer | Cédric Le Goater <clg@redhat.com> | 2023-10-18 10:10:49 +0200 |
| commit | fde4dbb7e61396a38fcc172ab02dbf839b468ebe (patch) | |
| tree | 545808fec01b5d85e0e0b6e797bdb560d8997539 | |
| parent | 7e63b3113889b531cbb56b09d69cc182608bb78e (diff) | |
vfio/pci: Fix a potential memory leak in vfio_listener_region_add
When there is an failure in vfio_listener_region_add() and the section
belongs to a ram device, there is an inaccurate error report which should
never be related to vfio_dma_map failure. The memory holding err is also
incrementally leaked in each failure.
Fix it by reporting the real error and free it.
Fixes: 567b5b309ab ("vfio/pci: Relax DMA map errors for MMIO regions")
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
| -rw-r--r-- | hw/vfio/common.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 9e61de03ee..5ff5acf1d8 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -763,7 +763,7 @@ static void vfio_listener_region_add(MemoryListener *listener, fail: if (memory_region_is_ram_device(section->mr)) { - error_report("failed to vfio_dma_map. pci p2p may not work"); + error_reportf_err(err, "PCI p2p may not work: "); return; } /* |