aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCong Liu <liucong2@kylinos.cn>2023-10-29 14:50:33 +0000
committerAlex Bennée <alex.bennee@linaro.org>2023-10-31 14:10:21 +0000
commit7f4527626910f21c9e4421236ee7a6383eb3ce2b (patch)
tree7620ed78e440f91847d7d671ff857f011dfc2b9e
parent946bf79e40a6296a46fa7cc4d8c06313ac012a95 (diff)
contrib/plugins: Close file descriptor on error return
This patch closes the file descriptor fd on error return to avoid resource leak. Fixes: ec7ee95db909 ("contrib/plugins: fix coverity warning in lockstep") Signed-off-by: Cong Liu <liucong2@kylinos.cn> Message-Id: <20231018025225.1640122-1-liucong2@kylinos.cn> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Message-Id: <20231029145033.592566-20-alex.bennee@linaro.org>
-rw-r--r--contrib/plugins/lockstep.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index f0cb8792c6..237543b43a 100644
--- a/contrib/plugins/lockstep.c
+++ b/contrib/plugins/lockstep.c
@@ -257,6 +257,7 @@ static bool setup_socket(const char *path)
sockaddr.sun_family = AF_UNIX;
if (g_strlcpy(sockaddr.sun_path, path, pathlen) >= pathlen) {
perror("bad path");
+ close(fd);
return false;
}
@@ -303,6 +304,7 @@ static bool connect_socket(const char *path)
sockaddr.sun_family = AF_UNIX;
if (g_strlcpy(sockaddr.sun_path, path, pathlen) >= pathlen) {
perror("bad path");
+ close(fd);
return false;
}